Skip to content

Commit

Permalink
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.c: drop incor…
Browse files Browse the repository at this point in the history
…rect checks

Dropped some "< 0" and ">= 0" checks on unsigned int values.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80501
Reported-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Andrey Utkin <andrey.krieger.utkin@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Andrey Utkin authored and Greg Kroah-Hartman committed Jul 18, 2014
1 parent f5439c6 commit ea702e7
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.c
Original file line number Diff line number Diff line change
Expand Up @@ -1750,34 +1750,34 @@ static int apci3200_ai_config(struct comedi_device *dev,
/* END JK 06.07.04: Management of sevrals boards */

if (data[5] == 0) {
if (ui_ChannelNo < 0 || ui_ChannelNo > 15) {
if (ui_ChannelNo > 15) {
printk("\nThe Selection of the channel is in error\n");
i_err++;
} /* if(ui_ChannelNo<0 || ui_ChannelNo>15) */
} /* if(ui_ChannelNo>15) */
} /* if(data[5]==0) */
else {
if (data[14] == 2) {
if (ui_ChannelNo < 0 || ui_ChannelNo > 3) {
if (ui_ChannelNo > 3) {
printk("\nThe Selection of the channel is in error\n");
i_err++;
} /* if(ui_ChannelNo<0 || ui_ChannelNo>3) */
} /* if(ui_ChannelNo>3) */
} /* if(data[14]==2) */
else {
if (ui_ChannelNo < 0 || ui_ChannelNo > 7) {
if (ui_ChannelNo > 7) {
printk("\nThe Selection of the channel is in error\n");
i_err++;
} /* if(ui_ChannelNo<0 || ui_ChannelNo>7) */
} /* if(ui_ChannelNo>7) */
} /* elseif(data[14]==2) */
} /* elseif(data[5]==0) */
if (data[12] == 0 || data[12] == 1) {
switch (data[5]) {
case 0:
if (ui_ChannelNo >= 0 && ui_ChannelNo <= 3) {
if (ui_ChannelNo <= 3) {
/* BEGIN JK 06.07.04: Management of sevrals boards */
/* i_Offset=0; */
s_BoardInfos[dev->minor].i_Offset = 0;
/* END JK 06.07.04: Management of sevrals boards */
} /* if(ui_ChannelNo >=0 && ui_ChannelNo <=3) */
} /* if(ui_ChannelNo <=3) */
if (ui_ChannelNo >= 4 && ui_ChannelNo <= 7) {
/* BEGIN JK 06.07.04: Management of sevrals boards */
/* i_Offset=64; */
Expand Down Expand Up @@ -1831,12 +1831,12 @@ static int apci3200_ai_config(struct comedi_device *dev,
ui_ChannelNo = 0;
break;
} /* if(data[14]==2) */
if (ui_ChannelNo >= 0 && ui_ChannelNo <= 1) {
if (ui_ChannelNo <= 1) {
/* BEGIN JK 06.07.04: Management of sevrals boards */
/* i_Offset=0; */
s_BoardInfos[dev->minor].i_Offset = 0;
/* END JK 06.07.04: Management of sevrals boards */
} /* if(ui_ChannelNo >=0 && ui_ChannelNo <=1) */
} /* if(ui_ChannelNo <=1) */
if (ui_ChannelNo >= 2 && ui_ChannelNo <= 3) {
/* BEGIN JK 06.07.04: Management of sevrals boards */
/* i_ChannelNo=i_ChannelNo-2; */
Expand Down

0 comments on commit ea702e7

Please sign in to comment.