Skip to content

Commit

Permalink
drm/i915: fix haswell linetime watermarks calculation
Browse files Browse the repository at this point in the history
Move the "*8"  calculation to the left side so we don't propagate
rounding errors. Also use DIV_ROUND_CLOSEST because that's what the
spec says we need to do.

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Paulo Zanoni authored and Daniel Vetter committed May 21, 2013
1 parent 7366937 commit eaa591e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/i915/intel_pm.c
Original file line number Diff line number Diff line change
@@ -2093,7 +2093,7 @@ haswell_update_linetime_wm(struct drm_device *dev, struct drm_crtc *crtc)
* row at the given clock rate, multiplied by 8.
* */
temp |= PIPE_WM_LINETIME_TIME(
((mode->htotal * 1000) / mode->clock) * 8);
DIV_ROUND_CLOSEST(mode->htotal * 1000 * 8, mode->clock));

/* IPS watermarks are only used by pipe A, and are ignored by
* pipes B and C. They are calculated similarly to the common

0 comments on commit eaa591e

Please sign in to comment.