Skip to content

Commit

Permalink
ALSA: oxfw: change function prototype for AV/C Audio Subunit command
Browse files Browse the repository at this point in the history 
ALSA OXFW driver uses AV/C Audio Subunit commands to control some models.
The commands get/set the state of Feature function block of the subunit.
The commands are not specific to OXFW, thus there's a possibility to use
them in the other drivers.

Currently, helper functions for the commands require 'struct snd_oxfw',
although, it's not necessarily required. It's better to change prototype
of the functions without the structure for future use.

This commit changes the prototype.

Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Takashi Sakamoto authored and Takashi Iwai committed Dec 15, 2015
1 parent 29aa09a commit eab8e4e
Showing 1 changed file with 31 additions and 23 deletions.
54 changes: 31 additions & 23 deletions sound/firewire/oxfw/oxfw-spkr.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ enum control_attribute {
CTL_CURRENT = 0x10,
};

static int spkr_mute_command(struct snd_oxfw *oxfw, bool *value,
enum control_action action)
static int avc_audio_feature_mute(struct fw_unit *unit, u8 fb_id, bool *value,
enum control_action action)
{
u8 *buf;
u8 response_ok;
Expand All @@ -35,7 +35,7 @@ static int spkr_mute_command(struct snd_oxfw *oxfw, bool *value,
buf[1] = 0x08; /* audio unit 0 */
buf[2] = 0xb8; /* FUNCTION BLOCK */
buf[3] = 0x81; /* function block type: feature */
buf[4] = oxfw->device_info->mute_fb_id; /* function block ID */
buf[4] = fb_id; /* function block ID */
buf[5] = 0x10; /* control attribute: current */
buf[6] = 0x02; /* selector length */
buf[7] = 0x00; /* audio channel number */
Expand All @@ -46,16 +46,16 @@ static int spkr_mute_command(struct snd_oxfw *oxfw, bool *value,
else
buf[10] = *value ? 0x70 : 0x60;

err = fcp_avc_transaction(oxfw->unit, buf, 11, buf, 11, 0x3fe);
err = fcp_avc_transaction(unit, buf, 11, buf, 11, 0x3fe);
if (err < 0)
goto error;
if (err < 11) {
dev_err(&oxfw->unit->device, "short FCP response\n");
dev_err(&unit->device, "short FCP response\n");
err = -EIO;
goto error;
}
if (buf[0] != response_ok) {
dev_err(&oxfw->unit->device, "mute command failed\n");
dev_err(&unit->device, "mute command failed\n");
err = -EIO;
goto error;
}
Expand All @@ -70,10 +70,10 @@ static int spkr_mute_command(struct snd_oxfw *oxfw, bool *value,
return err;
}

static int spkr_volume_command(struct snd_oxfw *oxfw, s16 *value,
unsigned int channel,
enum control_attribute attribute,
enum control_action action)
static int avc_audio_feature_volume(struct fw_unit *unit, u8 fb_id, s16 *value,
unsigned int channel,
enum control_attribute attribute,
enum control_action action)
{
u8 *buf;
u8 response_ok;
Expand All @@ -93,7 +93,7 @@ static int spkr_volume_command(struct snd_oxfw *oxfw, s16 *value,
buf[1] = 0x08; /* audio unit 0 */
buf[2] = 0xb8; /* FUNCTION BLOCK */
buf[3] = 0x81; /* function block type: feature */
buf[4] = oxfw->device_info->volume_fb_id; /* function block ID */
buf[4] = fb_id; /* function block ID */
buf[5] = attribute; /* control attribute */
buf[6] = 0x02; /* selector length */
buf[7] = channel; /* audio channel number */
Expand All @@ -107,16 +107,16 @@ static int spkr_volume_command(struct snd_oxfw *oxfw, s16 *value,
buf[11] = *value;
}

err = fcp_avc_transaction(oxfw->unit, buf, 12, buf, 12, 0x3fe);
err = fcp_avc_transaction(unit, buf, 12, buf, 12, 0x3fe);
if (err < 0)
goto error;
if (err < 12) {
dev_err(&oxfw->unit->device, "short FCP response\n");
dev_err(&unit->device, "short FCP response\n");
err = -EIO;
goto error;
}
if (buf[0] != response_ok) {
dev_err(&oxfw->unit->device, "volume command failed\n");
dev_err(&unit->device, "volume command failed\n");
err = -EIO;
goto error;
}
Expand Down Expand Up @@ -153,7 +153,8 @@ static int spkr_mute_put(struct snd_kcontrol *control,
if (mute == oxfw->mute)
return 0;

err = spkr_mute_command(oxfw, &mute, CTL_WRITE);
err = avc_audio_feature_mute(oxfw->unit, oxfw->device_info->mute_fb_id,
&mute, CTL_WRITE);
if (err < 0)
return err;
oxfw->mute = mute;
Expand Down Expand Up @@ -218,8 +219,10 @@ static int spkr_volume_put(struct snd_kcontrol *control,
for (i = 0; i <= oxfw->device_info->mixer_channels; ++i) {
volume = value->value.integer.value[channel_map[i ? i - 1 : 0]];
if (changed_channels & (1 << i)) {
err = spkr_volume_command(oxfw, &volume, i,
CTL_CURRENT, CTL_WRITE);
err = avc_audio_feature_volume(oxfw->unit,
oxfw->device_info->mute_fb_id,
&volume,
i, CTL_CURRENT, CTL_WRITE);
if (err < 0)
return err;
}
Expand Down Expand Up @@ -251,22 +254,27 @@ int snd_oxfw_add_spkr(struct snd_oxfw *oxfw)
unsigned int i, first_ch;
int err;

err = spkr_volume_command(oxfw, &oxfw->volume_min,
0, CTL_MIN, CTL_READ);
err = avc_audio_feature_volume(oxfw->unit,
oxfw->device_info->volume_fb_id,
&oxfw->volume_min, 0, CTL_MIN, CTL_READ);
if (err < 0)
return err;
err = spkr_volume_command(oxfw, &oxfw->volume_max,
0, CTL_MAX, CTL_READ);
err = avc_audio_feature_volume(oxfw->unit,
oxfw->device_info->volume_fb_id,
&oxfw->volume_max, 0, CTL_MAX, CTL_READ);
if (err < 0)
return err;

err = spkr_mute_command(oxfw, &oxfw->mute, CTL_READ);
err = avc_audio_feature_mute(oxfw->unit, oxfw->device_info->mute_fb_id,
&oxfw->mute, CTL_READ);
if (err < 0)
return err;

first_ch = oxfw->device_info->mixer_channels == 1 ? 0 : 1;
for (i = 0; i < oxfw->device_info->mixer_channels; ++i) {
err = spkr_volume_command(oxfw, &oxfw->volume[i],
err = avc_audio_feature_volume(oxfw->unit,
oxfw->device_info->volume_fb_id,
&oxfw->volume[i],
first_ch + i, CTL_CURRENT, CTL_READ);
if (err < 0)
return err;
Expand Down

0 comments on commit eab8e4e

Please sign in to comment.