Skip to content

Commit

Permalink
drivers/cpufreq/acpi-cpufreq.c: This fixes the following checkpatch w…
Browse files Browse the repository at this point in the history
…arning

WARNING: Prefer using '"%s...", __func__' to using function's name, in a
string

Switch hardcoded function name with a reference to __func__ making the
code more maintainable

Signed-off-by: Mohan Kumar <mohankumar718@gmail.com>
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Mohan Kumar authored and Rafael J. Wysocki committed Apr 16, 2019
1 parent 9df1e2c commit eae2ef0
Showing 1 changed file with 9 additions and 10 deletions.
19 changes: 9 additions & 10 deletions drivers/cpufreq/acpi-cpufreq.c
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ static u32 get_cur_val(const struct cpumask *mask, struct acpi_cpufreq_data *dat

val = drv_read(data, mask);

pr_debug("get_cur_val = %u\n", val);
pr_debug("%s = %u\n", __func__, val);

return val;
}
Expand All @@ -378,7 +378,7 @@ static unsigned int get_cur_freq_on_cpu(unsigned int cpu)
unsigned int freq;
unsigned int cached_freq;

pr_debug("get_cur_freq_on_cpu (%d)\n", cpu);
pr_debug("%s (%d)\n", __func__, cpu);

policy = cpufreq_cpu_get_raw(cpu);
if (unlikely(!policy))
Expand Down Expand Up @@ -458,8 +458,7 @@ static int acpi_cpufreq_target(struct cpufreq_policy *policy,
if (acpi_pstate_strict) {
if (!check_freqs(policy, mask,
policy->freq_table[index].frequency)) {
pr_debug("acpi_cpufreq_target failed (%d)\n",
policy->cpu);
pr_debug("%s (%d)\n", __func__, policy->cpu);
result = -EAGAIN;
}
}
Expand Down Expand Up @@ -573,7 +572,7 @@ static int cpufreq_boost_down_prep(unsigned int cpu)
static int __init acpi_cpufreq_early_init(void)
{
unsigned int i;
pr_debug("acpi_cpufreq_early_init\n");
pr_debug("%s\n", __func__);

acpi_perf_data = alloc_percpu(struct acpi_processor_performance);
if (!acpi_perf_data) {
Expand Down Expand Up @@ -657,7 +656,7 @@ static int acpi_cpufreq_cpu_init(struct cpufreq_policy *policy)
static int blacklisted;
#endif

pr_debug("acpi_cpufreq_cpu_init\n");
pr_debug("%s\n", __func__);

#ifdef CONFIG_SMP
if (blacklisted)
Expand Down Expand Up @@ -856,7 +855,7 @@ static int acpi_cpufreq_cpu_exit(struct cpufreq_policy *policy)
{
struct acpi_cpufreq_data *data = policy->driver_data;

pr_debug("acpi_cpufreq_cpu_exit\n");
pr_debug("%s\n", __func__);

policy->fast_switch_possible = false;
policy->driver_data = NULL;
Expand All @@ -881,7 +880,7 @@ static int acpi_cpufreq_resume(struct cpufreq_policy *policy)
{
struct acpi_cpufreq_data *data = policy->driver_data;

pr_debug("acpi_cpufreq_resume\n");
pr_debug("%s\n", __func__);

data->resume = 1;

Expand Down Expand Up @@ -954,7 +953,7 @@ static int __init acpi_cpufreq_init(void)
if (cpufreq_get_current_driver())
return -EEXIST;

pr_debug("acpi_cpufreq_init\n");
pr_debug("%s\n", __func__);

ret = acpi_cpufreq_early_init();
if (ret)
Expand Down Expand Up @@ -991,7 +990,7 @@ static int __init acpi_cpufreq_init(void)

static void __exit acpi_cpufreq_exit(void)
{
pr_debug("acpi_cpufreq_exit\n");
pr_debug("%s\n", __func__);

acpi_cpufreq_boost_exit();

Expand Down

0 comments on commit eae2ef0

Please sign in to comment.