Skip to content

Commit

Permalink
signal: check sig before setting info in kill_pid_usb_asyncio
Browse files Browse the repository at this point in the history
In kill_pid_usb_asyncio, if signal is not valid, we do not need to
set info struct.

Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Link: https://lore.kernel.org/r/f525fd08-1cf7-fb09-d20c-4359145eb940@huawei.com
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
  • Loading branch information
Zhiqiang Liu authored and Christian Brauner committed Apr 12, 2020
1 parent 8f3d9f3 commit eaec2b0
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions kernel/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -1510,15 +1510,15 @@ int kill_pid_usb_asyncio(int sig, int errno, sigval_t addr,
unsigned long flags;
int ret = -EINVAL;

if (!valid_signal(sig))
return ret;

clear_siginfo(&info);
info.si_signo = sig;
info.si_errno = errno;
info.si_code = SI_ASYNCIO;
*((sigval_t *)&info.si_pid) = addr;

if (!valid_signal(sig))
return ret;

rcu_read_lock();
p = pid_task(pid, PIDTYPE_PID);
if (!p) {
Expand Down

0 comments on commit eaec2b0

Please sign in to comment.