Skip to content

Commit

Permalink
xfs: remove a stale comment from xfs_file_aio_write_checks()
Browse files Browse the repository at this point in the history
The comment in xfs_file_aio_write_checks() about calling file_modified()
after dropping the ilock doesn't make sense, because the code that
unconditionally acquires and drops the ilock was removed by
commit 467f789 ("xfs: reduce ilock hold times in
xfs_file_aio_write_checks").

Remove this outdated comment.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
  • Loading branch information
Eric Biggers authored and Darrick J. Wong committed Jan 23, 2021
1 parent 3015196 commit eaf9254
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions fs/xfs/xfs_file.c
Original file line number Diff line number Diff line change
Expand Up @@ -389,12 +389,6 @@ xfs_file_aio_write_checks(
} else
spin_unlock(&ip->i_flags_lock);

/*
* Updating the timestamps will grab the ilock again from
* xfs_fs_dirty_inode, so we have to call it after dropping the
* lock above. Eventually we should look into a way to avoid
* the pointless lock roundtrip.
*/
return file_modified(file);
}

Expand Down

0 comments on commit eaf9254

Please sign in to comment.