Skip to content

Commit

Permalink
powerpc/asm: Convert .llong directives to .8byte
Browse files Browse the repository at this point in the history
.llong is an undocumented PPC specific directive. The generic
equivalent is .quad, but even better (because it's self describing) is
.8byte.

Convert all .llong directives to .8byte.

Signed-off-by: Tobin C. Harding <me@tobin.cc>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
  • Loading branch information
Tobin C. Harding authored and Michael Ellerman committed Aug 31, 2017
1 parent 5b59394 commit eb03916
Show file tree
Hide file tree
Showing 12 changed files with 40 additions and 40 deletions.
20 changes: 10 additions & 10 deletions arch/powerpc/boot/crt0.S
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,17 @@ _zimage_start_opd:

#ifdef __powerpc64__
.balign 8
p_start: .llong _start
p_etext: .llong _etext
p_bss_start: .llong __bss_start
p_end: .llong _end

p_toc: .llong __toc_start + 0x8000 - p_base
p_dyn: .llong __dynamic_start - p_base
p_rela: .llong __rela_dyn_start - p_base
p_prom: .llong 0
p_start: .8byte _start
p_etext: .8byte _etext
p_bss_start: .8byte __bss_start
p_end: .8byte _end

p_toc: .8byte __toc_start + 0x8000 - p_base
p_dyn: .8byte __dynamic_start - p_base
p_rela: .8byte __rela_dyn_start - p_base
p_prom: .8byte 0
.weak _platform_stack_top
p_pstack: .llong _platform_stack_top
p_pstack: .8byte _platform_stack_top
#else
p_start: .long _start
p_etext: .long _etext
Expand Down
2 changes: 1 addition & 1 deletion arch/powerpc/include/asm/asm-compat.h
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
#define PPC_LCMPI stringify_in_c(cmpdi)
#define PPC_LCMPLI stringify_in_c(cmpldi)
#define PPC_LCMP stringify_in_c(cmpd)
#define PPC_LONG stringify_in_c(.llong)
#define PPC_LONG stringify_in_c(.8byte)
#define PPC_LONG_ALIGN stringify_in_c(.balign 8)
#define PPC_TLNEI stringify_in_c(tdnei)
#define PPC_LLARX(t, a, b, eh) PPC_LDARX(t, a, b, eh)
Expand Down
6 changes: 3 additions & 3 deletions arch/powerpc/include/asm/feature-fixups.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@
*/
#if defined(CONFIG_PPC64) && !defined(__powerpc64__)
/* 64 bits kernel, 32 bits code (ie. vdso32) */
#define FTR_ENTRY_LONG .llong
#define FTR_ENTRY_LONG .8byte
#define FTR_ENTRY_OFFSET .long 0xffffffff; .long
#elif defined(CONFIG_PPC64)
#define FTR_ENTRY_LONG .llong
#define FTR_ENTRY_OFFSET .llong
#define FTR_ENTRY_LONG .8byte
#define FTR_ENTRY_OFFSET .8byte
#else
#define FTR_ENTRY_LONG .long
#define FTR_ENTRY_OFFSET .long
Expand Down
12 changes: 6 additions & 6 deletions arch/powerpc/include/asm/reg.h
Original file line number Diff line number Diff line change
Expand Up @@ -1344,12 +1344,12 @@ static inline void msr_check_and_clear(unsigned long bits)
".section __ftr_fixup,\"a\"\n" \
".align 3\n" \
"98:\n" \
" .llong %1\n" \
" .llong %1\n" \
" .llong 97b-98b\n" \
" .llong 99b-98b\n" \
" .llong 0\n" \
" .llong 0\n" \
" .8byte %1\n" \
" .8byte %1\n" \
" .8byte 97b-98b\n" \
" .8byte 99b-98b\n" \
" .8byte 0\n" \
" .8byte 0\n" \
".previous" \
: "=r" (rval) \
: "i" (CPU_FTR_CELL_TB_BUG), "i" (SPRN_TBRL) : "cr0"); \
Expand Down
2 changes: 1 addition & 1 deletion arch/powerpc/kernel/entry_64.S
Original file line number Diff line number Diff line change
Expand Up @@ -1104,7 +1104,7 @@ _ASM_NOKPROBE_SYMBOL(__enter_rtas)
_ASM_NOKPROBE_SYMBOL(rtas_return_loc)

.align 3
1: .llong rtas_restore_regs
1: .8byte rtas_restore_regs

rtas_restore_regs:
/* relocation is on at this point */
Expand Down
8 changes: 4 additions & 4 deletions arch/powerpc/kernel/head_64.S
Original file line number Diff line number Diff line change
Expand Up @@ -92,13 +92,13 @@ END_FTR_SECTION(0, 1)
.balign 8
.globl __secondary_hold_spinloop
__secondary_hold_spinloop:
.llong 0x0
.8byte 0x0

/* Secondary processors write this value with their cpu # */
/* after they enter the spin loop immediately below. */
.globl __secondary_hold_acknowledge
__secondary_hold_acknowledge:
.llong 0x0
.8byte 0x0

#ifdef CONFIG_RELOCATABLE
/* This flag is set to 1 by a loader if the kernel should run
Expand Down Expand Up @@ -650,7 +650,7 @@ __after_prom_start:
bctr

.balign 8
p_end: .llong _end - copy_to_here
p_end: .8byte _end - copy_to_here

4:
/*
Expand Down Expand Up @@ -892,7 +892,7 @@ _GLOBAL(relative_toc)
blr

.balign 8
p_toc: .llong __toc_start + 0x8000 - 0b
p_toc: .8byte __toc_start + 0x8000 - 0b

/*
* This is where the main kernel code starts.
Expand Down
6 changes: 3 additions & 3 deletions arch/powerpc/kernel/reloc_64.S
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ _GLOBAL(relocate)
6: blr

.balign 8
p_dyn: .llong __dynamic_start - 0b
p_rela: .llong __rela_dyn_start - 0b
p_st: .llong _stext - 0b
p_dyn: .8byte __dynamic_start - 0b
p_rela: .8byte __rela_dyn_start - 0b
p_st: .8byte _stext - 0b

14 changes: 7 additions & 7 deletions arch/powerpc/kernel/systbl.S
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,13 @@
#include <asm/ppc_asm.h>

#ifdef CONFIG_PPC64
#define SYSCALL(func) .llong DOTSYM(sys_##func),DOTSYM(sys_##func)
#define COMPAT_SYS(func) .llong DOTSYM(sys_##func),DOTSYM(compat_sys_##func)
#define PPC_SYS(func) .llong DOTSYM(ppc_##func),DOTSYM(ppc_##func)
#define OLDSYS(func) .llong DOTSYM(sys_ni_syscall),DOTSYM(sys_ni_syscall)
#define SYS32ONLY(func) .llong DOTSYM(sys_ni_syscall),DOTSYM(compat_sys_##func)
#define PPC64ONLY(func) .llong DOTSYM(ppc_##func),DOTSYM(sys_ni_syscall)
#define SYSX(f, f3264, f32) .llong DOTSYM(f),DOTSYM(f3264)
#define SYSCALL(func) .8byte DOTSYM(sys_##func),DOTSYM(sys_##func)
#define COMPAT_SYS(func) .8byte DOTSYM(sys_##func),DOTSYM(compat_sys_##func)
#define PPC_SYS(func) .8byte DOTSYM(ppc_##func),DOTSYM(ppc_##func)
#define OLDSYS(func) .8byte DOTSYM(sys_ni_syscall),DOTSYM(sys_ni_syscall)
#define SYS32ONLY(func) .8byte DOTSYM(sys_ni_syscall),DOTSYM(compat_sys_##func)
#define PPC64ONLY(func) .8byte DOTSYM(ppc_##func),DOTSYM(sys_ni_syscall)
#define SYSX(f, f3264, f32) .8byte DOTSYM(f),DOTSYM(f3264)
#else
#define SYSCALL(func) .long sys_##func
#define COMPAT_SYS(func) .long sys_##func
Expand Down
2 changes: 1 addition & 1 deletion arch/powerpc/platforms/powernv/opal-wrappers.S
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

.globl opal_tracepoint_refcount
opal_tracepoint_refcount:
.llong 0
.8byte 0

.section ".text"

Expand Down
2 changes: 1 addition & 1 deletion arch/powerpc/platforms/pseries/hvCall.S
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

.globl hcall_tracepoint_refcount
hcall_tracepoint_refcount:
.llong 0
.8byte 0

.section ".text"
#endif
Expand Down
4 changes: 2 additions & 2 deletions arch/powerpc/purgatory/trampoline.S
Original file line number Diff line number Diff line change
Expand Up @@ -104,13 +104,13 @@ master:
.balign 8
.globl kernel
kernel:
.llong 0x0
.8byte 0x0
.size kernel, . - kernel

.balign 8
.globl dt_offset
dt_offset:
.llong 0x0
.8byte 0x0
.size dt_offset, . - dt_offset


Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ message:
.section ".toc"
.balign 8
pattern:
.llong 0x5555AAAA5555AAAA
.8byte 0x5555AAAA5555AAAA

.text
FUNC_START(_start)
Expand Down

0 comments on commit eb03916

Please sign in to comment.