Skip to content

Commit

Permalink
libata: remove ata_is_nodata
Browse files Browse the repository at this point in the history
The only caller can just check for !ata_is_data instead.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Tejun Heo <tj@kernel.org>
  • Loading branch information
Christoph Hellwig authored and Tejun Heo committed Jul 19, 2016
1 parent 35303d5 commit eb0effd
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
2 changes: 1 addition & 1 deletion drivers/ata/libata-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -5044,7 +5044,7 @@ static void ata_verify_xfer(struct ata_queued_cmd *qc)
{
struct ata_device *dev = qc->dev;

if (ata_is_nodata(qc->tf.protocol))
if (!ata_is_data(qc->tf.protocol))
return;

if ((dev->mwdma_mask || dev->udma_mask) && ata_is_pio(qc->tf.protocol))
Expand Down
5 changes: 0 additions & 5 deletions include/linux/libata.h
Original file line number Diff line number Diff line change
Expand Up @@ -1070,11 +1070,6 @@ static inline bool ata_is_atapi(u8 prot)
return ata_prot_flags(prot) & ATA_PROT_FLAG_ATAPI;
}

static inline bool ata_is_nodata(u8 prot)
{
return !(ata_prot_flags(prot) & ATA_PROT_FLAG_DATA);
}

static inline bool ata_is_pio(u8 prot)
{
return ata_prot_flags(prot) & ATA_PROT_FLAG_PIO;
Expand Down

0 comments on commit eb0effd

Please sign in to comment.