Skip to content

Commit

Permalink
drm/rockchip: vop2: Demote message in mod_supported to drm_dbg_kms
Browse files Browse the repository at this point in the history
Checking if a modifier is supported by a plane is normal behavior. It is
normal that a plane may not support certain modifiers. Failing the check
doesn't justify an error message in the kernel log and may mislead
users.

Demote the error message to drm_dbg_kms to only print the message if the
respective debug messages are enabled. This is similar to the behavior
in rockchip_drm_vop.c.

Signed-off-by: Michael Tretter <m.tretter@pengutronix.de>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20231009103753.830458-1-m.tretter@pengutronix.de
  • Loading branch information
Michael Tretter authored and Heiko Stuebner committed Oct 9, 2023
1 parent 8badbaf commit eb23cff
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/gpu/drm/rockchip/rockchip_drm_vop2.c
Original file line number Diff line number Diff line change
Expand Up @@ -469,8 +469,8 @@ static bool rockchip_vop2_mod_supported(struct drm_plane *plane, u32 format,
return true;

if (!rockchip_afbc(plane, modifier)) {
drm_err(vop2->drm, "Unsupported format modifier 0x%llx\n",
modifier);
drm_dbg_kms(vop2->drm, "Unsupported format modifier 0x%llx\n",
modifier);

return false;
}
Expand Down

0 comments on commit eb23cff

Please sign in to comment.