Skip to content

Commit

Permalink
mxser: increase buf_overrun if tty_insert_flip_char() fails
Browse files Browse the repository at this point in the history
mxser doesn't increase port->icount.buf_overrun at all. Do so if overrun
happens, so that it can be read from the stats.

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Link: https://lore.kernel.org/r/20211118073125.12283-17-jslaby@suse.cz
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Jiri Slaby authored and Greg Kroah-Hartman committed Nov 25, 2021
1 parent 9dd6f30 commit eb68ac0
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions drivers/tty/mxser.c
Original file line number Diff line number Diff line change
Expand Up @@ -1507,7 +1507,8 @@ static bool mxser_receive_chars_new(struct mxser_port *port, u8 status)

while (gdl--) {
u8 ch = inb(port->ioaddr + UART_RX);
tty_insert_flip_char(&port->port, ch, 0);
if (!tty_insert_flip_char(&port->port, ch, 0))
port->icount.buf_overrun++;
}

return true;
Expand Down Expand Up @@ -1553,8 +1554,10 @@ static u8 mxser_receive_chars_old(struct tty_struct *tty,
port->icount.overrun++;
}
}
if (!tty_insert_flip_char(&port->port, ch, flag))
if (!tty_insert_flip_char(&port->port, ch, flag)) {
port->icount.buf_overrun++;
break;
}
}

if (hwid)
Expand Down

0 comments on commit eb68ac0

Please sign in to comment.