Skip to content

Commit

Permalink
sctp: Add infrastructure for per net sysctls
Browse files Browse the repository at this point in the history
Start with an empty sctp_net_table that will be populated as the various
tunable sysctls are made per net.

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Eric W. Biederman authored and David S. Miller committed Aug 15, 2012
1 parent b01a240 commit ebb7e95
Show file tree
Hide file tree
Showing 4 changed files with 37 additions and 1 deletion.
6 changes: 5 additions & 1 deletion include/net/netns/sctp.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,14 +4,17 @@
struct sock;
struct proc_dir_entry;
struct sctp_mib;
struct ctl_table_header;

struct netns_sctp {
DEFINE_SNMP_STAT(struct sctp_mib, sctp_statistics);

#ifdef CONFIG_PROC_FS
struct proc_dir_entry *proc_net_sctp;
#endif

#ifdef CONFIG_SYSCTL
struct ctl_table_header *sysctl_header;
#endif
/* This is the global socket data structure used for responding to
* the Out-of-the-blue (OOTB) packets. A control sock will be created
* for this socket at the initialization time.
Expand All @@ -32,6 +35,7 @@ struct netns_sctp {

/* Lock that protects the local_addr_list writers */
spinlock_t local_addr_lock;

};

#endif /* __NETNS_SCTP_H__ */
4 changes: 4 additions & 0 deletions include/net/sctp/sctp.h
Original file line number Diff line number Diff line change
Expand Up @@ -375,9 +375,13 @@ static inline void sctp_dbg_objcnt_exit(struct net *) { return; }
#if defined CONFIG_SYSCTL
void sctp_sysctl_register(void);
void sctp_sysctl_unregister(void);
int sctp_sysctl_net_register(struct net *net);
void sctp_sysctl_net_unregister(struct net *net);
#else
static inline void sctp_sysctl_register(void) { return; }
static inline void sctp_sysctl_unregister(void) { return; }
static inline int sctp_sysctl_net_register(struct net *net) { return 0; }
static inline void sctp_sysctl_net_unregister(struct net *net) { return; }
#endif

/* Size of Supported Address Parameter for 'x' address types. */
Expand Down
7 changes: 7 additions & 0 deletions net/sctp/protocol.c
Original file line number Diff line number Diff line change
Expand Up @@ -1169,6 +1169,10 @@ static int sctp_net_init(struct net *net)
{
int status;

status = sctp_sysctl_net_register(net);
if (status)
goto err_sysctl_register;

/* Allocate and initialise sctp mibs. */
status = init_sctp_mibs(net);
if (status)
Expand Down Expand Up @@ -1208,6 +1212,8 @@ static int sctp_net_init(struct net *net)
err_init_proc:
cleanup_sctp_mibs(net);
err_init_mibs:
sctp_sysctl_net_unregister(net);
err_sysctl_register:
return status;
}

Expand All @@ -1224,6 +1230,7 @@ static void sctp_net_exit(struct net *net)

sctp_proc_exit(net);
cleanup_sctp_mibs(net);
sctp_sysctl_net_unregister(net);
}

static struct pernet_operations sctp_net_ops = {
Expand Down
21 changes: 21 additions & 0 deletions net/sctp/sysctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,27 @@ static ctl_table sctp_table[] = {
{ /* sentinel */ }
};

static ctl_table sctp_net_table[] = {
{ /* sentinel */ }
};

int sctp_sysctl_net_register(struct net *net)
{
struct ctl_table *table;

table = kmemdup(sctp_net_table, sizeof(sctp_net_table), GFP_KERNEL);
if (!table)
return -ENOMEM;

net->sctp.sysctl_header = register_net_sysctl(net, "net/sctp", table);
return 0;
}

void sctp_sysctl_net_unregister(struct net *net)
{
unregister_net_sysctl_table(net->sctp.sysctl_header);
}

static struct ctl_table_header * sctp_sysctl_header;

/* Sysctl registration. */
Expand Down

0 comments on commit ebb7e95

Please sign in to comment.