Skip to content

Commit

Permalink
media: rcar-csi2: Add warning for PHY speed less than minimum
Browse files Browse the repository at this point in the history
Add a warning message when the selected PHY speed is less
than supported minimum PHY speed given in the hsfreq table[1].

For raspberry pi camera capture on Kingfisher board with resolution
640x480, the calculated PHY speed is 48 mbps which is less than
the minimum PHY speed 80 Mbps from the table[1]. But in this cases
capture is successful.

[1] specs r19uh0105ej0200-r-car-3rd-generation.pdf [Table 25.9]

Signed-off-by: Suresh Udipi <sudipi@jp.adit-jv.com>
Signed-off-by: Michael Rodin <mrodin@de.adit-jv.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
  • Loading branch information
Suresh Udipi authored and Mauro Carvalho Chehab committed Nov 30, 2021
1 parent cee44d4 commit ebeefe2
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/media/platform/rcar-vin/rcar-csi2.c
Original file line number Diff line number Diff line change
Expand Up @@ -544,6 +544,10 @@ static int rcsi2_set_phypll(struct rcar_csi2 *priv, unsigned int mbps)
const struct rcsi2_mbps_reg *hsfreq;
const struct rcsi2_mbps_reg *hsfreq_prev = NULL;

if (mbps < priv->info->hsfreqrange->mbps)
dev_warn(priv->dev, "%u Mbps less than min PHY speed %u Mbps",
mbps, priv->info->hsfreqrange->mbps);

for (hsfreq = priv->info->hsfreqrange; hsfreq->mbps != 0; hsfreq++) {
if (hsfreq->mbps >= mbps)
break;
Expand Down

0 comments on commit ebeefe2

Please sign in to comment.