Skip to content

Commit

Permalink
nuc900fb: don't treat NULL clk as an error
Browse files Browse the repository at this point in the history
clk_get() returns a struct clk cookie to the driver and some platforms
may return NULL if they only support a single clock.  clk_get() has only
failed if it returns a ERR_PTR() encoded pointer.

Cc: linux-fbdev@vger.kernel.org
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
Acked-by: Wan ZongShun <mcuos.com@gmail.com>
Signed-off-by: Paul Mundt <lethal@linux-sh.org>
  • Loading branch information
Jamie Iles authored and Paul Mundt committed Jan 12, 2011
1 parent 0b2e9cb commit ec03031
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/video/nuc900fb.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
*/
#include <linux/module.h>
#include <linux/kernel.h>
#include <linux/err.h>
#include <linux/errno.h>
#include <linux/string.h>
#include <linux/mm.h>
Expand Down Expand Up @@ -597,9 +598,9 @@ static int __devinit nuc900fb_probe(struct platform_device *pdev)
}

fbi->clk = clk_get(&pdev->dev, NULL);
if (!fbi->clk || IS_ERR(fbi->clk)) {
if (IS_ERR(fbi->clk)) {
printk(KERN_ERR "nuc900-lcd:failed to get lcd clock source\n");
ret = -ENOENT;
ret = PTR_ERR(fbi->clk);
goto release_irq;
}

Expand Down

0 comments on commit ec03031

Please sign in to comment.