Skip to content

Commit

Permalink
fpga: dfl: fme: Fix cpu hotplug issue in performance reporting
Browse files Browse the repository at this point in the history
The performance reporting driver added cpu hotplug
feature but it didn't add pmu migration call in cpu
offline function.
This can create an issue incase the current designated
cpu being used to collect fme pmu data got offline,
as based on current code we are not migrating fme pmu to
new target cpu. Because of that perf will still try to
fetch data from that offline cpu and hence we will not
get counter data.

Patch fixed this issue by adding pmu_migrate_context call
in fme_perf_offline_cpu function.

Fixes: 724142f ("fpga: dfl: fme: add performance reporting support")
Cc: stable@vger.kernel.org
Tested-by: Xu Yilun <yilun.xu@intel.com>
Acked-by: Wu Hao <hao.wu@intel.com>
Signed-off-by: Kajol Jain <kjain@linux.ibm.com>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
  • Loading branch information
Kajol Jain authored and Moritz Fischer committed Jul 27, 2021
1 parent ff11764 commit ec6446d
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/fpga/dfl-fme-perf.c
Original file line number Diff line number Diff line change
@@ -953,6 +953,8 @@ static int fme_perf_offline_cpu(unsigned int cpu, struct hlist_node *node)
return 0;

priv->cpu = target;
perf_pmu_migrate_context(&priv->pmu, cpu, target);

return 0;
}

0 comments on commit ec6446d

Please sign in to comment.