Skip to content

Commit

Permalink
drm/panel: sharp-lq101r1sx01: Fixed reversed "if" in remove
Browse files Browse the repository at this point in the history
Commit d7d473d ("drm/panel: sharp-lq101r1sx01: Don't call disable
at shutdown/remove") had a subtle bug. We should be calling
sharp_panel_del() when the "sharp" variable is non-NULL, not when it's
NULL. Fix.

Fixes: d7d473d ("drm/panel: sharp-lq101r1sx01: Don't call disable at shutdown/remove")
Cc: Thierry Reding <treding@nvidia.com>
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202406261525.SkhtM3ZV-lkp@intel.com/
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240708105221.1.I576751c661c7edb6b804dda405d10e2e71153e32@changeid
  • Loading branch information
Douglas Anderson committed Jul 9, 2024
1 parent cb31c58 commit ec85147
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/panel/panel-sharp-lq101r1sx01.c
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,7 @@ static void sharp_panel_remove(struct mipi_dsi_device *dsi)
dev_err(&dsi->dev, "failed to detach from DSI host: %d\n", err);

/* only detach from host for the DSI-LINK2 interface */
if (!sharp)
if (sharp)
sharp_panel_del(sharp);
}

Expand Down

0 comments on commit ec85147

Please sign in to comment.