Skip to content

Commit

Permalink
soc: samsung: exynos-pmu: Fix uninitialized ret in tensor_set_bits_at…
Browse files Browse the repository at this point in the history
…omic()

If tensor_set_bits_atomic() is called with a mask of 0 the function will
just iterate over its bit, not perform any updates and return stack
value of 'ret'.

Also reported by smatch:

  drivers/soc/samsung/exynos-pmu.c:129 tensor_set_bits_atomic() error: uninitialized symbol 'ret'.

Fixes: 0b7c607 ("soc: samsung: exynos-pmu: Add regmap support for SoCs that protect PMU regs")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20250104135605.109209-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
  • Loading branch information
Krzysztof Kozlowski committed Jan 6, 2025
1 parent 38405d3 commit eca836d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/soc/samsung/exynos-pmu.c
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ static int tensor_set_bits_atomic(void *ctx, unsigned int offset, u32 val,
if (ret)
return ret;
}
return ret;
return 0;
}

static bool tensor_is_atomic(unsigned int reg)
Expand Down

0 comments on commit eca836d

Please sign in to comment.