Skip to content

Commit

Permalink
dmaengine: mediatek: drop bogus pm_runtime_set_active()
Browse files Browse the repository at this point in the history
The runtime PM state must be updated while runtime PM is disabled for
the change to take effect.

Drop the bogus pm_runtime_set_active() which left the PM state set to
suspended (as it should be or the clock would not be enabled when the
device is resumed).

Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20230622075150.885-1-johan+linaro@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
  • Loading branch information
Johan Hovold authored and Vinod Koul committed Jul 12, 2023
1 parent 3533913 commit ecc3cfc
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/dma/mediatek/mtk-uart-apdma.c
Original file line number Diff line number Diff line change
Expand Up @@ -551,7 +551,6 @@ static int mtk_uart_apdma_probe(struct platform_device *pdev)
}

pm_runtime_enable(&pdev->dev);
pm_runtime_set_active(&pdev->dev);

rc = dma_async_device_register(&mtkd->ddev);
if (rc)
Expand Down

0 comments on commit ecc3cfc

Please sign in to comment.