Skip to content

Commit

Permalink
aacraid: Set correct msix count for EEH recovery
Browse files Browse the repository at this point in the history
During EEH recovery number of online CPU's might change thereby changing
the number of MSIx vectors. Since each fib is allocated to a vector,
changes in the number of vectors causes fib to be sent thru invalid
vectors.In addition the correct number of MSIx vectors is not updated in
the INIT struct sent to the controller, when it is reinitialized.

Fixed by reassigning vectors to fibs based on the updated number of MSIx
vectors and updating the INIT structure before sending to controller.

Fixes: MSI-X vector calculation for suspend/resume
Cc: stable@vger.kernel.org

Signed-off-by: Raghava Aditya Renukunta <raghavaaditya.renukunta@pmcs.com>
Reviewed-by: Shane Seymour <shane.seymour@hpe.com>
Reviewed-by: Johannes Thumshirn <jthushirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
  • Loading branch information
Raghava Aditya Renukunta authored and Martin K. Petersen committed Feb 24, 2016
1 parent f88fa79 commit ecc479e
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion drivers/scsi/aacraid/linit.c
Original file line number Diff line number Diff line change
Expand Up @@ -1409,8 +1409,18 @@ static int aac_acquire_resources(struct aac_dev *dev)

aac_adapter_enable_int(dev);

if (!dev->sync_mode)
/*max msix may change after EEH
* Re-assign vectors to fibs
*/
aac_fib_vector_assign(dev);

if (!dev->sync_mode) {
/* After EEH recovery or suspend resume, max_msix count
* may change, therfore updating in init as well.
*/
aac_adapter_start(dev);
dev->init->Sa_MSIXVectors = cpu_to_le32(dev->max_msix);
}
return 0;

error_iounmap:
Expand Down

0 comments on commit ecc479e

Please sign in to comment.