Skip to content

Commit

Permalink
gpio: stp-xway: Simplify using devm_clk_get_enabled()
Browse files Browse the repository at this point in the history
Use devm_clk_get_enabled() simplify xway_stp_probe().

Signed-off-by: Rong Qianfeng <rongqianfeng@vivo.com>
Link: https://lore.kernel.org/r/20240820121651.29706-2-rongqianfeng@vivo.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
  • Loading branch information
Rong Qianfeng authored and Bartosz Golaszewski committed Sep 2, 2024
1 parent d25f9ab commit ece70e7
Showing 1 changed file with 2 additions and 8 deletions.
10 changes: 2 additions & 8 deletions drivers/gpio/gpio-stp-xway.c
Original file line number Diff line number Diff line change
Expand Up @@ -296,23 +296,17 @@ static int xway_stp_probe(struct platform_device *pdev)
if (!of_property_read_bool(pdev->dev.of_node, "lantiq,rising"))
chip->edge = XWAY_STP_FALLING;

clk = devm_clk_get(&pdev->dev, NULL);
clk = devm_clk_get_enabled(&pdev->dev, NULL);
if (IS_ERR(clk)) {
dev_err(&pdev->dev, "Failed to get clock\n");
return PTR_ERR(clk);
}

ret = clk_prepare_enable(clk);
if (ret)
return ret;

xway_stp_hw_init(chip);

ret = devm_gpiochip_add_data(&pdev->dev, &chip->gc, chip);
if (ret) {
clk_disable_unprepare(clk);
if (ret)
return ret;
}

dev_info(&pdev->dev, "Init done\n");

Expand Down

0 comments on commit ece70e7

Please sign in to comment.