Skip to content

Commit

Permalink
nfs: avoid dereferencing null pointer in initiate_bulk_draining
Browse files Browse the repository at this point in the history
Fix an inverted null pointer check in initiate_bulk_draining().

Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: stable@vger.kernel.org [>= 3.7]
  • Loading branch information
Nickolai Zeldovich authored and Trond Myklebust committed Jan 5, 2013
1 parent 360e1a5 commit ecf0eb9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/nfs/callback_proc.c
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ static u32 initiate_bulk_draining(struct nfs_client *clp,

list_for_each_entry(lo, &server->layouts, plh_layouts) {
ino = igrab(lo->plh_inode);
if (ino)
if (!ino)
continue;
spin_lock(&ino->i_lock);
/* Is this layout in the process of being freed? */
Expand Down

0 comments on commit ecf0eb9

Please sign in to comment.