Skip to content

Commit

Permalink
scsi: storvsc: Reduce default ring buffer size to 128 Kbytes
Browse files Browse the repository at this point in the history
Reduce the default VMbus channel ring buffer size for storvsc SCSI devices
from 1 Mbyte to 128 Kbytes. Measurements show that ring buffer sizes above
128 Kbytes do not increase performance even at very high IOPS rates, so
don't waste the memory. Also remove the dependence on PAGE_SIZE, since the
ring buffer size should not change on architectures where PAGE_SIZE is not
4 Kbytes.

Signed-off-by: Michael Kelley <mikelley@microsoft.com>
Reviewed-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
  • Loading branch information
Michael Kelley authored and Martin K. Petersen committed Apr 4, 2019
1 parent 382e06d commit ed2e63a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/scsi/storvsc_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -385,7 +385,7 @@ enum storvsc_request_type {
* This is the end of Protocol specific defines.
*/

static int storvsc_ringbuffer_size = (256 * PAGE_SIZE);
static int storvsc_ringbuffer_size = (128 * 1024);
static u32 max_outstanding_req_per_channel;

static int storvsc_vcpus_per_sub_channel = 4;
Expand Down

0 comments on commit ed2e63a

Please sign in to comment.