Skip to content

Commit

Permalink
PM / devfreq: event: Call of_node_put() only once in devfreq_event_ge…
Browse files Browse the repository at this point in the history
…t_edev_by_phandle()

An of_node_put(node) call was immediately used after a null pointer check
for the local variable “edev” at the end of this function implementation.
Thus call such a function only once instead directly before the check.

This issue was transformed by using the Coccinelle software.

Link: https://lore.kernel.org/lkml/0f103384-376c-41f0-a35c-8ad98327d6cb@web.de/
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Chanwoo Choi <cw00.choi@samsung.com>
  • Loading branch information
Markus Elfring authored and Chanwoo Choi committed Dec 8, 2024
1 parent 40384c8 commit ed33fbb
Showing 1 changed file with 2 additions and 6 deletions.
8 changes: 2 additions & 6 deletions drivers/devfreq/devfreq-event.c
Original file line number Diff line number Diff line change
Expand Up @@ -244,13 +244,9 @@ struct devfreq_event_dev *devfreq_event_get_edev_by_phandle(struct device *dev,
edev = NULL;
out:
mutex_unlock(&devfreq_event_list_lock);

if (!edev) {
of_node_put(node);
return ERR_PTR(-ENODEV);
}

of_node_put(node);
if (!edev)
return ERR_PTR(-ENODEV);

return edev;
}
Expand Down

0 comments on commit ed33fbb

Please sign in to comment.