Skip to content

Commit

Permalink
clk: sunxi-ng: mux: Fix determine_rate for mux clocks with pre-dividers
Browse files Browse the repository at this point in the history
The determine_rate helper used ccu_mux_helper_adjust_parent_for_prediv()
to adjust the parent_rate to account for pre-dividers, but then passed
the pristine parent clock rate from clk_hw_get_rate() to the round()
callback, thereby ignoring the pre-divider adjustment. In addition,
it was saving the adjusted parent rate back into struct
clk_rate_request.

This patch fixes this by saving the pristine parent clock rate, and
adding a copy that is adjusted and passed to the round() callback.
The pristine copy, if it is the best solution, would be saved back
to struct clk_rate_request.

Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
  • Loading branch information
Chen-Yu Tsai authored and Maxime Ripard committed Jan 30, 2017
1 parent 64afa89 commit ed48205
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions drivers/clk/sunxi-ng/ccu_mux.c
Original file line number Diff line number Diff line change
Expand Up @@ -71,18 +71,19 @@ int ccu_mux_helper_determine_rate(struct ccu_common *common,
unsigned int i;

for (i = 0; i < clk_hw_get_num_parents(hw); i++) {
unsigned long tmp_rate, parent_rate;
unsigned long tmp_rate, parent_rate, adj_parent_rate;
struct clk_hw *parent;

parent = clk_hw_get_parent_by_index(hw, i);
if (!parent)
continue;

parent_rate = clk_hw_get_rate(parent);
adj_parent_rate = parent_rate;
ccu_mux_helper_adjust_parent_for_prediv(common, cm, i,
&parent_rate);
&adj_parent_rate);

tmp_rate = round(cm, clk_hw_get_rate(parent), req->rate, data);
tmp_rate = round(cm, adj_parent_rate, req->rate, data);
if (tmp_rate == req->rate) {
best_parent = parent;
best_parent_rate = parent_rate;
Expand Down

0 comments on commit ed48205

Please sign in to comment.