Skip to content

Commit

Permalink
dt-bindings: dmaengine: Convert Allwinner A31 and A64 DMA to a schema
Browse files Browse the repository at this point in the history
The newer Allwinner SoCs have a DMA controller supported in Linux, with a
matching Device Tree binding.

Now that we have the DT validation in place, let's convert the device tree
bindings for that controller over to a YAML schemas.

Reviewed-by: Rob Herring <robh@kernel.org>
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Link: https://lore.kernel.org/r/20190720092607.31095-3-maxime.ripard@bootlin.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
  • Loading branch information
Maxime Ripard authored and Vinod Koul committed Jul 29, 2019
1 parent 545a29c commit edd1421
Show file tree
Hide file tree
Showing 3 changed files with 150 additions and 81 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
# SPDX-License-Identifier: GPL-2.0
%YAML 1.2
---
$id: http://devicetree.org/schemas/dma/allwinner,sun50i-a64-dma.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#

title: Allwinner A64 DMA Controller Device Tree Bindings

maintainers:
- Chen-Yu Tsai <wens@csie.org>
- Maxime Ripard <maxime.ripard@bootlin.com>

allOf:
- $ref: "dma-controller.yaml#"

properties:
"#dma-cells":
const: 1
description: The cell is the request line number.

compatible:
enum:
- allwinner,sun50i-a64-dma
- allwinner,sun50i-h6-dma

reg:
maxItems: 1

interrupts:
maxItems: 1

clocks:
minItems: 1
maxItems: 2

clock-names:
items:
- const: bus
- const: mbus

resets:
maxItems: 1

required:
- "#dma-cells"
- compatible
- reg
- interrupts
- clocks
- resets
- dma-channels

if:
properties:
compatible:
const: allwinner,sun50i-h6-dma

then:
properties:
clocks:
maxItems: 2

required:
- clock-names

else:
properties:
clocks:
maxItems: 1

# FIXME: We should set it, but it would report all the generic
# properties as additional properties.
# additionalProperties: false

examples:
- |
dma: dma-controller@1c02000 {
compatible = "allwinner,sun50i-a64-dma";
reg = <0x01c02000 0x1000>;
interrupts = <0 50 4>;
clocks = <&ccu 30>;
dma-channels = <8>;
dma-requests = <27>;
resets = <&ccu 7>;
#dma-cells = <1>;
};
...
62 changes: 62 additions & 0 deletions Documentation/devicetree/bindings/dma/allwinner,sun6i-a31-dma.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
# SPDX-License-Identifier: GPL-2.0
%YAML 1.2
---
$id: http://devicetree.org/schemas/dma/allwinner,sun6i-a31-dma.yaml#
$schema: http://devicetree.org/meta-schemas/core.yaml#

title: Allwinner A31 DMA Controller Device Tree Bindings

maintainers:
- Chen-Yu Tsai <wens@csie.org>
- Maxime Ripard <maxime.ripard@bootlin.com>

allOf:
- $ref: "dma-controller.yaml#"

properties:
"#dma-cells":
const: 1
description: The cell is the request line number.

compatible:
oneOf:
- const: allwinner,sun6i-a31-dma
- const: allwinner,sun8i-a23-dma
- const: allwinner,sun8i-a83t-dma
- const: allwinner,sun8i-h3-dma
- const: allwinner,sun8i-v3s-dma

reg:
maxItems: 1

interrupts:
maxItems: 1

clocks:
maxItems: 1

resets:
maxItems: 1

required:
- "#dma-cells"
- compatible
- reg
- interrupts
- clocks
- resets

additionalProperties: false

examples:
- |
dma: dma-controller@1c02000 {
compatible = "allwinner,sun6i-a31-dma";
reg = <0x01c02000 0x1000>;
interrupts = <0 50 4>;
clocks = <&ahb1_gates 6>;
resets = <&ahb1_rst 6>;
#dma-cells = <1>;
};
...
81 changes: 0 additions & 81 deletions Documentation/devicetree/bindings/dma/sun6i-dma.txt

This file was deleted.

0 comments on commit edd1421

Please sign in to comment.