Skip to content

Commit

Permalink
tracing: use union for multi-usages field
Browse files Browse the repository at this point in the history
Impact: cleanup

struct dyn_ftrace::ip has different usages in his lifecycle,
we use union for it. And also for struct dyn_ftrace::flags.

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: Steven Rostedt <srostedt@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
LKML-Reference: <49C871BE.3080405@cn.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
Lai Jiangshan authored and Ingo Molnar committed Mar 24, 2009
1 parent cc59c9e commit ee000b7
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 7 deletions.
12 changes: 9 additions & 3 deletions include/linux/ftrace.h
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,15 @@ enum {
};

struct dyn_ftrace {
unsigned long ip; /* address of mcount call-site */
unsigned long flags;
struct dyn_arch_ftrace arch;
union {
unsigned long ip; /* address of mcount call-site */
struct dyn_ftrace *freelist;
};
union {
unsigned long flags;
struct dyn_ftrace *newlist;
};
struct dyn_arch_ftrace arch;
};

int ftrace_force_update(void);
Expand Down
8 changes: 4 additions & 4 deletions kernel/trace/ftrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -341,7 +341,7 @@ static inline int record_frozen(struct dyn_ftrace *rec)

static void ftrace_free_rec(struct dyn_ftrace *rec)
{
rec->ip = (unsigned long)ftrace_free_records;
rec->freelist = ftrace_free_records;
ftrace_free_records = rec;
rec->flags |= FTRACE_FL_FREE;
}
Expand Down Expand Up @@ -379,7 +379,7 @@ static struct dyn_ftrace *ftrace_alloc_dyn_node(unsigned long ip)
return NULL;
}

ftrace_free_records = (void *)rec->ip;
ftrace_free_records = rec->freelist;
memset(rec, 0, sizeof(*rec));
return rec;
}
Expand Down Expand Up @@ -411,7 +411,7 @@ ftrace_record_ip(unsigned long ip)
return NULL;

rec->ip = ip;
rec->flags = (unsigned long)ftrace_new_addrs;
rec->newlist = ftrace_new_addrs;
ftrace_new_addrs = rec;

return rec;
Expand Down Expand Up @@ -731,7 +731,7 @@ static int ftrace_update_code(struct module *mod)
return -1;

p = ftrace_new_addrs;
ftrace_new_addrs = (struct dyn_ftrace *)p->flags;
ftrace_new_addrs = p->newlist;
p->flags = 0L;

/* convert record (i.e, patch mcount-call with NOP) */
Expand Down

0 comments on commit ee000b7

Please sign in to comment.