Skip to content

Commit

Permalink
procfs: kill ->write_proc()
Browse files Browse the repository at this point in the history
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Al Viro committed Apr 9, 2013
1 parent ff9046a commit ee21ed0
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 26 deletions.
25 changes: 0 additions & 25 deletions fs/proc/generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -196,30 +196,6 @@ proc_file_read(struct file *file, char __user *buf, size_t nbytes,
return rv;
}

static ssize_t
proc_file_write(struct file *file, const char __user *buffer,
size_t count, loff_t *ppos)
{
struct proc_dir_entry *pde = PDE(file_inode(file));
ssize_t rv = -EIO;

if (pde->write_proc) {
spin_lock(&pde->pde_unload_lock);
if (!pde->proc_fops) {
spin_unlock(&pde->pde_unload_lock);
return rv;
}
pde->pde_users++;
spin_unlock(&pde->pde_unload_lock);

/* FIXME: does this routine need ppos? probably... */
rv = pde->write_proc(file, buffer, count, pde->data);
pde_users_dec(pde);
}
return rv;
}


static loff_t
proc_file_lseek(struct file *file, loff_t offset, int orig)
{
Expand All @@ -239,7 +215,6 @@ proc_file_lseek(struct file *file, loff_t offset, int orig)
static const struct file_operations proc_file_operations = {
.llseek = proc_file_lseek,
.read = proc_file_read,
.write = proc_file_write,
};

static int proc_notify_change(struct dentry *dentry, struct iattr *iattr)
Expand Down
1 change: 0 additions & 1 deletion include/linux/proc_fs.h
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ struct proc_dir_entry {
struct proc_dir_entry *next, *parent, *subdir;
void *data;
read_proc_t *read_proc;
write_proc_t *write_proc;
atomic_t count; /* use count */
int pde_users; /* number of callers into module in progress */
struct completion *pde_unload_completion;
Expand Down

0 comments on commit ee21ed0

Please sign in to comment.