Skip to content

Commit

Permalink
ARM: mmp: MMP2 drive strength FAST using wrong value
Browse files Browse the repository at this point in the history
Drive strength for MMP2 is a 2 bit value but because of the mapping in
plat-pxa/mfp.h needs to be shifted up one bit to handle real
location in mfp registers.  (MMP2 and PXA910 drive strength start
at bit 11 while PXA168 starts at bit 10).

Values 0, 1, 2, and 3 effectively need to be
0, 2, 4, and 6 to fit into register.  8 does not work.

Signed-off-by: Philip Rakity <prakity@marvell.com>
Tested-by: John Watlington <wad@laptop.org>
Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
  • Loading branch information
Philip Rakity authored and Eric Miao committed Jan 15, 2011
1 parent a1015a1 commit ee309d3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/arm/mach-mmp/include/mach/mfp-mmp2.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#define MFP_DRIVE_VERY_SLOW (0x0 << 13)
#define MFP_DRIVE_SLOW (0x2 << 13)
#define MFP_DRIVE_MEDIUM (0x4 << 13)
#define MFP_DRIVE_FAST (0x8 << 13)
#define MFP_DRIVE_FAST (0x6 << 13)

/* GPIO */
#define GPIO0_GPIO MFP_CFG(GPIO0, AF0)
Expand Down

0 comments on commit ee309d3

Please sign in to comment.