Skip to content

Commit

Permalink
USB: serial: core: fix up printk() usage
Browse files Browse the repository at this point in the history
This moves to using pr_info() where needed instead of a "raw" printk()
call, making the whole driver more unified.

It also cleans up my email address in the MODULE_AUTHOR field.

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Greg Kroah-Hartman committed Sep 18, 2012
1 parent f378dfe commit ee42f6c
Showing 1 changed file with 3 additions and 10 deletions.
13 changes: 3 additions & 10 deletions drivers/usb/serial/usb-serial.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,7 @@
#include <linux/kfifo.h>
#include "pl2303.h"

/*
* Version Information
*/
#define DRIVER_AUTHOR "Greg Kroah-Hartman, greg@kroah.com, http://www.kroah.com/linux/"
#define DRIVER_AUTHOR "Greg Kroah-Hartman <gregkh@linuxfoundation.org>"
#define DRIVER_DESC "USB Serial Driver core"

/* There is no MODULE_DEVICE_TABLE for usbserial.c. Instead
Expand Down Expand Up @@ -1264,8 +1261,6 @@ static int __init usb_serial_init(void)
goto exit_generic;
}

printk(KERN_INFO KBUILD_MODNAME ": " DRIVER_DESC "\n");

return result;

exit_generic:
Expand Down Expand Up @@ -1350,17 +1345,15 @@ static int usb_serial_register(struct usb_serial_driver *driver)
pr_err("problem %d when registering driver %s\n", retval, driver->description);
list_del(&driver->driver_list);
} else
printk(KERN_INFO "USB Serial support registered for %s\n",
driver->description);
pr_info("USB Serial support registered for %s\n", driver->description);

mutex_unlock(&table_lock);
return retval;
}

static void usb_serial_deregister(struct usb_serial_driver *device)
{
printk(KERN_INFO "USB Serial deregistering driver %s\n",
device->description);
pr_info("USB Serial deregistering driver %s\n", device->description);
mutex_lock(&table_lock);
list_del(&device->driver_list);
usb_serial_bus_deregister(device);
Expand Down

0 comments on commit ee42f6c

Please sign in to comment.