Skip to content

Commit

Permalink
fs: pstore: Replaced calls to kmalloc and memcpy with kmemdup
Browse files Browse the repository at this point in the history
Replaced calls to kmalloc and memcpy with a single call to kmemdup.
This patch was found using coccicheck.

Signed-off-by: Alexandru Gheorghiu <gheorghiuandru@gmail.com>
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Tony Luck <tony.luck@intel.com>
  • Loading branch information
Alexandru Gheorghiu authored and Tony Luck committed Mar 11, 2013
1 parent f6161aa commit eeb65d9
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions fs/pstore/ram.c
Original file line number Diff line number Diff line change
Expand Up @@ -156,10 +156,9 @@ static ssize_t ramoops_pstore_read(u64 *id, enum pstore_type_id *type,
time->tv_nsec = 0;

size = persistent_ram_old_size(prz);
*buf = kmalloc(size, GFP_KERNEL);
*buf = kmemdup(persistent_ram_old(prz), size, GFP_KERNEL);
if (*buf == NULL)
return -ENOMEM;
memcpy(*buf, persistent_ram_old(prz), size);

return size;
}
Expand Down

0 comments on commit eeb65d9

Please sign in to comment.