Skip to content

Commit

Permalink
drm/shmem: drop DEFINE_DRM_GEM_SHMEM_FOPS
Browse files Browse the repository at this point in the history
DEFINE_DRM_GEM_SHMEM_FOPS is identical
to DEFINE_DRM_GEM_FOPS now, drop it.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Acked-by: Rob Herring <robh@kernel.org>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20191016115203.20095-6-kraxel@redhat.com
  • Loading branch information
Gerd Hoffmann committed Oct 17, 2019
1 parent 1bf01e1 commit eee9a2e
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 31 deletions.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/cirrus/cirrus.c
Original file line number Diff line number Diff line change
Expand Up @@ -510,7 +510,7 @@ static void cirrus_mode_config_init(struct cirrus_device *cirrus)

/* ------------------------------------------------------------------ */

DEFINE_DRM_GEM_SHMEM_FOPS(cirrus_fops);
DEFINE_DRM_GEM_FOPS(cirrus_fops);

static struct drm_driver cirrus_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
Expand Down
2 changes: 1 addition & 1 deletion drivers/gpu/drm/panfrost/panfrost_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@ static const struct drm_ioctl_desc panfrost_drm_driver_ioctls[] = {
PANFROST_IOCTL(MADVISE, madvise, DRM_RENDER_ALLOW),
};

DEFINE_DRM_GEM_SHMEM_FOPS(panfrost_drm_driver_fops);
DEFINE_DRM_GEM_FOPS(panfrost_drm_driver_fops);

/*
* Panfrost driver version:
Expand Down
2 changes: 1 addition & 1 deletion drivers/gpu/drm/tiny/gm12u320.c
Original file line number Diff line number Diff line change
Expand Up @@ -649,7 +649,7 @@ static void gm12u320_driver_release(struct drm_device *dev)
kfree(gm12u320);
}

DEFINE_DRM_GEM_SHMEM_FOPS(gm12u320_fops);
DEFINE_DRM_GEM_FOPS(gm12u320_fops);

static struct drm_driver gm12u320_drm_driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_ATOMIC,
Expand Down
2 changes: 1 addition & 1 deletion drivers/gpu/drm/v3d/v3d_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ v3d_postclose(struct drm_device *dev, struct drm_file *file)
kfree(v3d_priv);
}

DEFINE_DRM_GEM_SHMEM_FOPS(v3d_drm_fops);
DEFINE_DRM_GEM_FOPS(v3d_drm_fops);

/* DRM_AUTH is required on SUBMIT_CL for now, while we don't have GMP
* protection between clients. Note that render nodes would be be
Expand Down
2 changes: 1 addition & 1 deletion drivers/gpu/drm/virtio/virtgpu_drv.c
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ MODULE_AUTHOR("Dave Airlie <airlied@redhat.com>");
MODULE_AUTHOR("Gerd Hoffmann <kraxel@redhat.com>");
MODULE_AUTHOR("Alon Levy");

DEFINE_DRM_GEM_SHMEM_FOPS(virtio_gpu_driver_fops);
DEFINE_DRM_GEM_FOPS(virtio_gpu_driver_fops);

static struct drm_driver driver = {
.driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_RENDER | DRIVER_ATOMIC,
Expand Down
26 changes: 0 additions & 26 deletions include/drm/drm_gem_shmem_helper.h
Original file line number Diff line number Diff line change
Expand Up @@ -88,32 +88,6 @@ struct drm_gem_shmem_object {
#define to_drm_gem_shmem_obj(obj) \
container_of(obj, struct drm_gem_shmem_object, base)

/**
* DEFINE_DRM_GEM_SHMEM_FOPS() - Macro to generate file operations for shmem drivers
* @name: name for the generated structure
*
* This macro autogenerates a suitable &struct file_operations for shmem based
* drivers, which can be assigned to &drm_driver.fops. Note that this structure
* cannot be shared between drivers, because it contains a reference to the
* current module using THIS_MODULE.
*
* Note that the declaration is already marked as static - if you need a
* non-static version of this you're probably doing it wrong and will break the
* THIS_MODULE reference by accident.
*/
#define DEFINE_DRM_GEM_SHMEM_FOPS(name) \
static const struct file_operations name = {\
.owner = THIS_MODULE,\
.open = drm_open,\
.release = drm_release,\
.unlocked_ioctl = drm_ioctl,\
.compat_ioctl = drm_compat_ioctl,\
.poll = drm_poll,\
.read = drm_read,\
.llseek = noop_llseek,\
.mmap = drm_gem_mmap, \
}

struct drm_gem_shmem_object *drm_gem_shmem_create(struct drm_device *dev, size_t size);
void drm_gem_shmem_free_object(struct drm_gem_object *obj);

Expand Down

0 comments on commit eee9a2e

Please sign in to comment.