Skip to content

Commit

Permalink
KVM: Drop unused @may_block param from gfn_to_pfn_cache_invalidate_st…
Browse files Browse the repository at this point in the history
…art()

Remove gfn_to_pfn_cache_invalidate_start()'s unused @may_block parameter,
which was leftover from KVM's abandoned (for now) attempt to support guest
usage of gfn_to_pfn caches.

Fixes: a4bff3d ("KVM: pfncache: remove KVM_GUEST_USES_PFN usage")
Reported-by: Like Xu <like.xu.linux@gmail.com>
Cc: Paul Durrant <paul@xen.org>
Cc: David Woodhouse <dwmw2@infradead.org>
Reviewed-by: Paul Durrant <paul@xen.org>
Reviewed-by: David Woodhouse <dwmw@amazon.co.uk>
Link: https://lore.kernel.org/r/20240305003742.245767-1-seanjc@google.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
  • Loading branch information
Sean Christopherson committed Apr 11, 2024
1 parent 40e0ee6 commit eefb85b
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 7 deletions.
3 changes: 1 addition & 2 deletions virt/kvm/kvm_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -832,8 +832,7 @@ static int kvm_mmu_notifier_invalidate_range_start(struct mmu_notifier *mn,
* mn_active_invalidate_count (see above) instead of
* mmu_invalidate_in_progress.
*/
gfn_to_pfn_cache_invalidate_start(kvm, range->start, range->end,
hva_range.may_block);
gfn_to_pfn_cache_invalidate_start(kvm, range->start, range->end);

/*
* If one or more memslots were found and thus zapped, notify arch code
Expand Down
6 changes: 2 additions & 4 deletions virt/kvm/kvm_mm.h
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,11 @@ kvm_pfn_t hva_to_pfn(unsigned long addr, bool atomic, bool interruptible,
#ifdef CONFIG_HAVE_KVM_PFNCACHE
void gfn_to_pfn_cache_invalidate_start(struct kvm *kvm,
unsigned long start,
unsigned long end,
bool may_block);
unsigned long end);
#else
static inline void gfn_to_pfn_cache_invalidate_start(struct kvm *kvm,
unsigned long start,
unsigned long end,
bool may_block)
unsigned long end)
{
}
#endif /* HAVE_KVM_PFNCACHE */
Expand Down
2 changes: 1 addition & 1 deletion virt/kvm/pfncache.c
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
* MMU notifier 'invalidate_range_start' hook.
*/
void gfn_to_pfn_cache_invalidate_start(struct kvm *kvm, unsigned long start,
unsigned long end, bool may_block)
unsigned long end)
{
struct gfn_to_pfn_cache *gpc;

Expand Down

0 comments on commit eefb85b

Please sign in to comment.