Skip to content

Commit

Permalink
[LIB] crc32c: Keep intermediate crc state in cpu order
Browse files Browse the repository at this point in the history
crypto/crc32.c:chksum_final() is computing the digest as
*(__le32 *)out = ~cpu_to_le32(mctx->crc);
so the low-level crc32c_le routines should just keep
the crc in cpu order, otherwise it is getting swabbed
one too many times on big-endian machines.

Signed-off-by: Benny Halevy <bhalevy@fs1.bhalevy.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
  • Loading branch information
Benny Halevy authored and Herbert Xu committed Nov 8, 2007
1 parent dbeeb81 commit ef19454
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions lib/libcrc32c.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
#include <linux/crc32c.h>
#include <linux/compiler.h>
#include <linux/module.h>
#include <asm/byteorder.h>

MODULE_AUTHOR("Clay Haapala <chaapala@cisco.com>");
MODULE_DESCRIPTION("CRC32c (Castagnoli) calculations");
Expand Down Expand Up @@ -161,15 +160,13 @@ static const u32 crc32c_table[256] = {
*/

u32 __pure
crc32c_le(u32 seed, unsigned char const *data, size_t length)
crc32c_le(u32 crc, unsigned char const *data, size_t length)
{
u32 crc = __cpu_to_le32(seed);

while (length--)
crc =
crc32c_table[(crc ^ *data++) & 0xFFL] ^ (crc >> 8);

return __le32_to_cpu(crc);
return crc;
}

#endif /* CRC_LE_BITS == 8 */
Expand Down

0 comments on commit ef19454

Please sign in to comment.