Skip to content

Commit

Permalink
USB: symbolserial: remove unused private data
Browse files Browse the repository at this point in the history
Use port device for debug messages in interrupt-urb callback and remove
unused private data.

Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Johan Hovold authored and Greg Kroah-Hartman committed Apr 17, 2013
1 parent cced926 commit ef31025
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions drivers/usb/serial/symbolserial.c
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,10 @@ static const struct usb_device_id id_table[] = {
};
MODULE_DEVICE_TABLE(usb, id_table);

/* This structure holds all of the individual device information */
struct symbol_private {
struct usb_device *udev;
spinlock_t lock; /* protects the following flags */
bool throttled;
bool actually_throttled;
bool rts;
};

static void symbol_int_callback(struct urb *urb)
Expand Down Expand Up @@ -77,7 +74,7 @@ static void symbol_int_callback(struct urb *urb)
tty_insert_flip_string(&port->port, &data[1], data_length);
tty_flip_buffer_push(&port->port);
} else {
dev_dbg(&priv->udev->dev,
dev_dbg(&port->dev,
"Improper amount of data received from the device, "
"%d bytes", urb->actual_length);
}
Expand Down Expand Up @@ -170,7 +167,6 @@ static int symbol_startup(struct usb_serial *serial)
return -ENOMEM;
}
spin_lock_init(&priv->lock);
priv->udev = serial->dev;

usb_set_serial_data(serial, priv);
return 0;
Expand Down

0 comments on commit ef31025

Please sign in to comment.