Skip to content

Commit

Permalink
drm/amdkfd: bug fix for out of bounds mem on gpu cache filling info
Browse files Browse the repository at this point in the history
The bitmap in cu_info structure is defined as a 4x4 size array. In
Acturus, this matrix is initialized as a 4x2. Based on the 8 shaders.
In the gpu cache filling initialization, the access to the bitmap matrix
was done as an 8x1 instead of 4x2. Causing an out of bounds memory
access error.
Due to this, the number of GPU cache entries was inconsistent.

Signed-off-by: Alex Sierra <alex.sierra@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
  • Loading branch information
Alex Sierra authored and Alex Deucher committed Oct 30, 2019
1 parent 533bfca commit ef66915
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/amd/amdkfd/kfd_crat.c
Original file line number Diff line number Diff line change
@@ -710,7 +710,7 @@ static int kfd_fill_gpu_cache_info(struct kfd_dev *kdev,
pcache_info,
cu_info,
mem_available,
cu_info->cu_bitmap[i][j],
cu_info->cu_bitmap[i % 4][j + i / 4],
ct,
cu_processor_id,
k);

0 comments on commit ef66915

Please sign in to comment.