Skip to content

Commit

Permalink
USB: typec: tps6598x: Add status trace for tps25750
Browse files Browse the repository at this point in the history
tps25750 status register is a subset of tps6598x status register, hence
a trace for tps25750 status register is added.

Signed-off-by: Abdel Alkuor <abdelalkuor@geotab.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Link: https://lore.kernel.org/r/20231003155842.57313-10-alkuor@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Abdel Alkuor authored and Greg Kroah-Hartman committed Oct 10, 2023
1 parent e5d4a41 commit efa33cd
Show file tree
Hide file tree
Showing 2 changed files with 38 additions and 0 deletions.
1 change: 1 addition & 0 deletions drivers/usb/typec/tipd/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -1412,6 +1412,7 @@ static const struct tipd_data tps25750_data = {
.irq_handler = tps25750_interrupt,
.register_port = tps25750_register_port,
.trace_power_status = trace_tps25750_power_status,
.trace_status = trace_tps25750_status,
.apply_patch = tps25750_apply_patch,
};

Expand Down
37 changes: 37 additions & 0 deletions drivers/usb/typec/tipd/trace.h
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,14 @@
TPS_STATUS_USB_HOST_PRESENT_MASK | \
TPS_STATUS_LEGACY_MASK))

#define TPS25750_STATUS_FLAGS_MASK (GENMASK(31, 0) ^ (TPS_STATUS_CONN_STATE_MASK | \
GENMASK(19, 7) | \
TPS_STATUS_VBUS_STATUS_MASK | \
TPS_STATUS_USB_HOST_PRESENT_MASK | \
TPS_STATUS_LEGACY_MASK | \
BIT(26) | \
GENMASK(31, 28)))

#define show_status_conn_state(status) \
__print_symbolic(TPS_STATUS_CONN_STATE((status)), \
{ TPS_STATUS_CONN_STATE_CONN_WITH_R_A, "conn-Ra" }, \
Expand Down Expand Up @@ -148,6 +156,14 @@
{ TPS_STATUS_HIGH_VOLAGE_WARNING, "HIGH_VOLAGE_WARNING" }, \
{ TPS_STATUS_HIGH_LOW_VOLTAGE_WARNING, "HIGH_LOW_VOLTAGE_WARNING" })

#define show_tps25750_status_flags(flags) \
__print_flags((flags & TPS25750_STATUS_FLAGS_MASK), "|", \
{ TPS_STATUS_PLUG_PRESENT, "PLUG_PRESENT" }, \
{ TPS_STATUS_PLUG_UPSIDE_DOWN, "UPSIDE_DOWN" }, \
{ TPS_STATUS_PORTROLE, "PORTROLE" }, \
{ TPS_STATUS_DATAROLE, "DATAROLE" }, \
{ TPS_STATUS_BIST, "BIST" })

#define show_power_status_source_sink(power_status) \
__print_symbolic(TPS_POWER_STATUS_SOURCESINK(power_status), \
{ 1, "sink" }, \
Expand Down Expand Up @@ -292,6 +308,27 @@ TRACE_EVENT(tps6598x_status,
)
);

TRACE_EVENT(tps25750_status,
TP_PROTO(u32 status),
TP_ARGS(status),

TP_STRUCT__entry(
__field(u32, status)
),

TP_fast_assign(
__entry->status = status;
),

TP_printk("conn: %s, vbus: %s, usb-host: %s, legacy: %s, flags: %s",
show_status_conn_state(__entry->status),
show_status_vbus_status(__entry->status),
show_status_usb_host_present(__entry->status),
show_status_legacy(__entry->status),
show_tps25750_status_flags(__entry->status)
)
);

TRACE_EVENT(tps6598x_power_status,
TP_PROTO(u16 power_status),
TP_ARGS(power_status),
Expand Down

0 comments on commit efa33cd

Please sign in to comment.