module: Fix gratuitous sprintf in module.c

Andrew sent an older version of this patch: we shouldn't use sprintf to copy a string. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
mariux64 · Jan 29, 2008 · efa5345 · efa5345
1 parent c9a3ba5
commit efa5345
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/kernel/module.c b/kernel/module.c
@@ -738,7 +738,7 @@ sys_delete_module(const char __user *name_user, unsigned int flags)
 		mutex_lock(&module_mutex);
 	}
 	/* Store the name of the last unloaded module for diagnostic purposes */
-	sprintf(last_unloaded_module, mod->name);
+	strlcpy(last_unloaded_module, mod->name, sizeof(last_unloaded_module));
 	free_module(mod);
 
  out: