Skip to content

Commit

Permalink
usb: common: convert to use match_string() helper
Browse files Browse the repository at this point in the history
The new helper returns index of the mathing string in an array.  We
would use it here.

Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Heikki Krogerus authored and Linus Torvalds committed Mar 17, 2016
1 parent 9adb925 commit efc2cd7
Showing 1 changed file with 8 additions and 14 deletions.
22 changes: 8 additions & 14 deletions drivers/usb/common/common.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,18 +64,15 @@ EXPORT_SYMBOL_GPL(usb_speed_string);
enum usb_device_speed usb_get_maximum_speed(struct device *dev)
{
const char *maximum_speed;
int err;
int i;
int ret;

err = device_property_read_string(dev, "maximum-speed", &maximum_speed);
if (err < 0)
ret = device_property_read_string(dev, "maximum-speed", &maximum_speed);
if (ret < 0)
return USB_SPEED_UNKNOWN;

for (i = 0; i < ARRAY_SIZE(speed_names); i++)
if (strcmp(maximum_speed, speed_names[i]) == 0)
return i;
ret = match_string(speed_names, ARRAY_SIZE(speed_names), maximum_speed);

return USB_SPEED_UNKNOWN;
return (ret < 0) ? USB_SPEED_UNKNOWN : ret;
}
EXPORT_SYMBOL_GPL(usb_get_maximum_speed);

Expand Down Expand Up @@ -109,13 +106,10 @@ static const char *const usb_dr_modes[] = {

static enum usb_dr_mode usb_get_dr_mode_from_string(const char *str)
{
int i;

for (i = 0; i < ARRAY_SIZE(usb_dr_modes); i++)
if (!strcmp(usb_dr_modes[i], str))
return i;
int ret;

return USB_DR_MODE_UNKNOWN;
ret = match_string(usb_dr_modes, ARRAY_SIZE(usb_dr_modes), str);
return (ret < 0) ? USB_DR_MODE_UNKNOWN : ret;
}

enum usb_dr_mode usb_get_dr_mode(struct device *dev)
Expand Down

0 comments on commit efc2cd7

Please sign in to comment.