Skip to content

Commit

Permalink
cpuset: introduce CS_ONLINE
Browse files Browse the repository at this point in the history
Add CS_ONLINE which is set from css_online() and cleared from
css_offline().  This will enable using generic cgroup iterator while
allowing decoupling cpuset from cgroup internal locking.

Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Li Zefan <lizefan@huawei.com>
  • Loading branch information
Tejun Heo committed Jan 7, 2013
1 parent c8f699b commit efeb77b
Showing 1 changed file with 10 additions and 1 deletion.
11 changes: 10 additions & 1 deletion kernel/cpuset.c
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ static inline bool task_has_mempolicy(struct task_struct *task)

/* bits in struct cpuset flags field */
typedef enum {
CS_ONLINE,
CS_CPU_EXCLUSIVE,
CS_MEM_EXCLUSIVE,
CS_MEM_HARDWALL,
Expand All @@ -154,6 +155,11 @@ enum hotplug_event {
};

/* convenient tests for these bits */
static inline bool is_cpuset_online(const struct cpuset *cs)
{
return test_bit(CS_ONLINE, &cs->flags);
}

static inline int is_cpu_exclusive(const struct cpuset *cs)
{
return test_bit(CS_CPU_EXCLUSIVE, &cs->flags);
Expand Down Expand Up @@ -190,7 +196,8 @@ static inline int is_spread_slab(const struct cpuset *cs)
}

static struct cpuset top_cpuset = {
.flags = ((1 << CS_CPU_EXCLUSIVE) | (1 << CS_MEM_EXCLUSIVE)),
.flags = ((1 << CS_ONLINE) | (1 << CS_CPU_EXCLUSIVE) |
(1 << CS_MEM_EXCLUSIVE)),
};

/*
Expand Down Expand Up @@ -1822,6 +1829,7 @@ static int cpuset_css_online(struct cgroup *cgrp)
if (!parent)
return 0;

set_bit(CS_ONLINE, &cs->flags);
if (is_spread_page(parent))
set_bit(CS_SPREAD_PAGE, &cs->flags);
if (is_spread_slab(parent))
Expand Down Expand Up @@ -1871,6 +1879,7 @@ static void cpuset_css_offline(struct cgroup *cgrp)
update_flag(CS_SCHED_LOAD_BALANCE, cs, 0);

number_of_cpusets--;
clear_bit(CS_ONLINE, &cs->flags);

cgroup_unlock();
}
Expand Down

0 comments on commit efeb77b

Please sign in to comment.