Skip to content

Commit

Permalink
irqchip/realtek-rtl: Fix refcount leak in map_interrupts
Browse files Browse the repository at this point in the history
of_find_node_by_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
This function doesn't call of_node_put() in error path.
Call of_node_put() directly after of_property_read_u32() to cover
both normal path and error path.

Fixes: 9f3a0f3 ("irqchip: Add support for Realtek RTL838x/RTL839x interrupt controller")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220601080930.31005-7-linmq006@gmail.com
  • Loading branch information
Miaoqian Lin authored and Marc Zyngier committed Jun 9, 2022
1 parent fa1ad9d commit eff4780
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/irqchip/irq-realtek-rtl.c
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,9 @@ static int __init map_interrupts(struct device_node *node, struct irq_domain *do
if (!cpu_ictl)
return -EINVAL;
ret = of_property_read_u32(cpu_ictl, "#interrupt-cells", &tmp);
of_node_put(cpu_ictl);
if (ret || tmp != 1)
return -EINVAL;
of_node_put(cpu_ictl);

cpu_int = be32_to_cpup(imap + 2);
if (cpu_int > 7 || cpu_int < 2)
Expand Down

0 comments on commit eff4780

Please sign in to comment.