Skip to content

Commit

Permalink
uio: potential double frees if __uio_register_device() fails
Browse files Browse the repository at this point in the history
The uio_unregister_device() function assumes that if "info->uio_dev" is
non-NULL that means "info" is fully allocated.  Setting info->uio_de
has to be the last thing in the function.

In the current code, if request_threaded_irq() fails then we return with
info->uio_dev set to non-NULL but info is not fully allocated and it can
lead to double frees.

Fixes: beafc54 ("UIO: Add the User IO core code")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Dan Carpenter authored and Greg Kroah-Hartman committed Aug 2, 2018
1 parent c01513b commit f019f07
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/uio/uio.c
Original file line number Diff line number Diff line change
Expand Up @@ -953,8 +953,6 @@ int __uio_register_device(struct module *owner,
if (ret)
goto err_uio_dev_add_attributes;

info->uio_dev = idev;

if (info->irq && (info->irq != UIO_IRQ_CUSTOM)) {
/*
* Note that we deliberately don't use devm_request_irq
Expand All @@ -971,6 +969,7 @@ int __uio_register_device(struct module *owner,
goto err_request_irq;
}

info->uio_dev = idev;
return 0;

err_request_irq:
Expand Down

0 comments on commit f019f07

Please sign in to comment.