Skip to content

Commit

Permalink
optee: fix invalid of_node_put() in optee_driver_init()
Browse files Browse the repository at this point in the history
The first node supplied to of_find_matching_node() has its reference
counter decreased as part of call to that function. In optee_driver_init()
after calling of_find_matching_node() it's invalid to call of_node_put() on
the supplied node again.

So remove the invalid call to of_node_put().

Reported-by: Alex Shi <alex.shi@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
  • Loading branch information
Jens Wiklander committed Nov 29, 2017
1 parent 4fbd8d1 commit f044113
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/tee/optee/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -590,7 +590,6 @@ static int __init optee_driver_init(void)
return -ENODEV;

np = of_find_matching_node(fw_np, optee_match);
of_node_put(fw_np);
if (!np)
return -ENODEV;

Expand Down

0 comments on commit f044113

Please sign in to comment.