Skip to content

Commit

Permalink
net/inetdevice: bad_mask can be boolean
Browse files Browse the repository at this point in the history
This patch makes bad_mask return bool due to this particular function
only using either one or zero as its return value.

No functional change.

Signed-off-by: Yaowei Bai <bywxiaobai@163.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Yaowei Bai authored and David S. Miller committed Oct 9, 2015
1 parent c322516 commit f06cc7b
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions include/linux/inetdevice.h
Original file line number Diff line number Diff line change
Expand Up @@ -180,15 +180,15 @@ static __inline__ bool inet_ifa_match(__be32 addr, struct in_ifaddr *ifa)
* Check if a mask is acceptable.
*/

static __inline__ int bad_mask(__be32 mask, __be32 addr)
static __inline__ bool bad_mask(__be32 mask, __be32 addr)
{
__u32 hmask;
if (addr & (mask = ~mask))
return 1;
return true;
hmask = ntohl(mask);
if (hmask & (hmask+1))
return 1;
return 0;
return true;
return false;
}

#define for_primary_ifa(in_dev) { struct in_ifaddr *ifa; \
Expand Down

0 comments on commit f06cc7b

Please sign in to comment.