Skip to content

Commit

Permalink
ksmbd: fix subauth 0 handling in sid_to_id()
Browse files Browse the repository at this point in the history
It's not obvious why subauth 0 would be excluded from translation. This
would lead to wrong results whenever a non-identity idmapping is used.

Cc: Steve French <stfrench@microsoft.com>
Cc: Christoph Hellwig <hch@infradead.org>
Cc: Namjae Jeon <namjae.jeon@samsung.com>
Cc: Hyunchul Lee <hyc.lee@gmail.com>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: linux-cifs@vger.kernel.org
Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
  • Loading branch information
Christian Brauner authored and Steve French committed Sep 4, 2021
1 parent 0e844ef commit f0bb29d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions fs/ksmbd/smbacl.c
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ static int sid_to_id(struct user_namespace *user_ns,
uid_t id;

id = le32_to_cpu(psid->sub_auth[psid->num_subauth - 1]);
if (id > 0) {
if (id >= 0) {
uid = make_kuid(user_ns, id);
if (uid_valid(uid) && kuid_has_mapping(user_ns, uid)) {
fattr->cf_uid = uid;
Expand All @@ -286,7 +286,7 @@ static int sid_to_id(struct user_namespace *user_ns,
gid_t id;

id = le32_to_cpu(psid->sub_auth[psid->num_subauth - 1]);
if (id > 0) {
if (id >= 0) {
gid = make_kgid(user_ns, id);
if (gid_valid(gid) && kgid_has_mapping(user_ns, gid)) {
fattr->cf_gid = gid;
Expand Down

0 comments on commit f0bb29d

Please sign in to comment.