Skip to content

Commit

Permalink
check_unsafe_exec() doesn't care about signal handlers sharing
Browse files Browse the repository at this point in the history
... since we'll unshare sighand anyway

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Al Viro committed Apr 1, 2009
1 parent 498052b commit f1191b5
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions fs/exec.c
Original file line number Diff line number Diff line change
Expand Up @@ -1060,23 +1060,20 @@ int check_unsafe_exec(struct linux_binprm *bprm)
{
struct task_struct *p = current, *t;
unsigned long flags;
unsigned n_fs, n_sighand;
unsigned n_fs;
int res = 0;

bprm->unsafe = tracehook_unsafe_exec(p);

n_fs = 1;
n_sighand = 1;
write_lock(&p->fs->lock);
lock_task_sighand(p, &flags);
for (t = next_thread(p); t != p; t = next_thread(t)) {
if (t->fs == p->fs)
n_fs++;
n_sighand++;
}

if (p->fs->users > n_fs ||
atomic_read(&p->sighand->count) > n_sighand) {
if (p->fs->users > n_fs) {
bprm->unsafe |= LSM_UNSAFE_SHARE;
} else {
if (p->fs->in_exec)
Expand Down

0 comments on commit f1191b5

Please sign in to comment.