Skip to content

Commit

Permalink
MIPS: ath79: simplify ath79_gpio_function_* routines
Browse files Browse the repository at this point in the history
Make ath79_gpio_function_{en,dis}able to be wrappers
around ath79_gpio_function_setup.

Signed-off-by: Gabor Juhos <juhosg@openwrt.org>
Patchwork: http://patchwork.linux-mips.org/patch/4871/
Signed-off-by: John Crispin <blogic@openwrt.org>
  • Loading branch information
Gabor Juhos authored and John Crispin committed Feb 17, 2013
1 parent 8838bec commit f160a28
Showing 1 changed file with 6 additions and 24 deletions.
30 changes: 6 additions & 24 deletions arch/mips/ath79/gpio.c
Original file line number Diff line number Diff line change
Expand Up @@ -154,46 +154,28 @@ static void __iomem *ath79_gpio_get_function_reg(void)
return ath79_gpio_base + reg;
}

void ath79_gpio_function_enable(u32 mask)
void ath79_gpio_function_setup(u32 set, u32 clear)
{
void __iomem *reg = ath79_gpio_get_function_reg();
unsigned long flags;

spin_lock_irqsave(&ath79_gpio_lock, flags);

__raw_writel(__raw_readl(reg) | mask, reg);
__raw_writel((__raw_readl(reg) & ~clear) | set, reg);
/* flush write */
__raw_readl(reg);

spin_unlock_irqrestore(&ath79_gpio_lock, flags);
}

void ath79_gpio_function_disable(u32 mask)
void ath79_gpio_function_enable(u32 mask)
{
void __iomem *reg = ath79_gpio_get_function_reg();
unsigned long flags;

spin_lock_irqsave(&ath79_gpio_lock, flags);

__raw_writel(__raw_readl(reg) & ~mask, reg);
/* flush write */
__raw_readl(reg);

spin_unlock_irqrestore(&ath79_gpio_lock, flags);
ath79_gpio_function_setup(mask, 0);
}

void ath79_gpio_function_setup(u32 set, u32 clear)
void ath79_gpio_function_disable(u32 mask)
{
void __iomem *reg = ath79_gpio_get_function_reg();
unsigned long flags;

spin_lock_irqsave(&ath79_gpio_lock, flags);

__raw_writel((__raw_readl(reg) & ~clear) | set, reg);
/* flush write */
__raw_readl(reg);

spin_unlock_irqrestore(&ath79_gpio_lock, flags);
ath79_gpio_function_setup(0, mask);
}

void __init ath79_gpio_init(void)
Expand Down

0 comments on commit f160a28

Please sign in to comment.