Skip to content

Commit

Permalink
drm/tegra: hub: Increase buffer size to ensure all possible values ca…
Browse files Browse the repository at this point in the history
…n be stored

When converting from int to string, we must allow for up to 10-chars (2147483647).

Fixes the following W=1 kernel build warning(s):

 drivers/gpu/drm/tegra/hub.c: In function ‘tegra_display_hub_probe’:
 drivers/gpu/drm/tegra/hub.c:1106:47: warning: ‘%u’ directive output may be truncated writing between 1 and 10 bytes into a region of size 4 [-Wformat-truncation=]
 drivers/gpu/drm/tegra/hub.c:1106:42: note: directive argument in the range [0, 4294967294]
 drivers/gpu/drm/tegra/hub.c:1106:17: note: ‘snprintf’ output between 6 and 15 bytes into a destination of size 8

Signed-off-by: Lee Jones <lee@kernel.org>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230824073710.2677348-16-lee@kernel.org
  • Loading branch information
Lee Jones authored and Thierry Reding committed Oct 11, 2023
1 parent 753c977 commit f170bed
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/tegra/hub.c
Original file line number Diff line number Diff line change
Expand Up @@ -1101,7 +1101,7 @@ static int tegra_display_hub_probe(struct platform_device *pdev)

for (i = 0; i < hub->soc->num_wgrps; i++) {
struct tegra_windowgroup *wgrp = &hub->wgrps[i];
char id[8];
char id[16];

snprintf(id, sizeof(id), "wgrp%u", i);
mutex_init(&wgrp->lock);
Expand Down

0 comments on commit f170bed

Please sign in to comment.