Skip to content

Commit

Permalink
drm/imagination: Fix ERR_PTR test on pointer to pointer.
Browse files Browse the repository at this point in the history
drivers/gpu/drm/imagination/pvr_vm.c:631 pvr_vm_create_context()
  error: 'vm_ctx->mmu_ctx' dereferencing possible ERR_PTR()

612         vm_ctx->mmu_ctx = pvr_mmu_context_create(pvr_dev);
613         err = PTR_ERR_OR_ZERO(&vm_ctx->mmu_ctx);
                                      ^
The address is never an error pointer so this will always return 0.
Remove the ampersand.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Donald Robson <donald.robson@imgtec.com>
Signed-off-by: Maxime Ripard <mripard@kernel.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20231213144431.94956-1-donald.robson@imgtec.com
  • Loading branch information
Donald Robson authored and Maxime Ripard committed Dec 15, 2023
1 parent f1f55ed commit f175498
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/gpu/drm/imagination/pvr_vm.c
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,7 @@ pvr_vm_create_context(struct pvr_device *pvr_dev, bool is_userspace_context)
0, 1ULL << device_addr_bits, 0, 0, &pvr_vm_gpuva_ops);

vm_ctx->mmu_ctx = pvr_mmu_context_create(pvr_dev);
err = PTR_ERR_OR_ZERO(&vm_ctx->mmu_ctx);
err = PTR_ERR_OR_ZERO(vm_ctx->mmu_ctx);
if (err) {
vm_ctx->mmu_ctx = NULL;
goto err_put_ctx;
Expand Down

0 comments on commit f175498

Please sign in to comment.