Skip to content

Commit

Permalink
virtio_net: use non-reentrant workqueue.
Browse files Browse the repository at this point in the history
Michael S. Tsirkin also noticed that we could run the refill work
multiple CPUs: if we kick off a refill on one CPU and then on another,
they would both manipulate the queue at the same time (they use
napi_disable to avoid racing against the receive handler itself).

Tejun points out that this is what the WQ_NON_REENTRANT flag is for,
and that there is a convenient system kthread we can use.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Rusty Russell authored and David S. Miller committed Dec 29, 2011
1 parent b2baed6 commit f1776da
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions drivers/net/virtio_net.c
Original file line number Diff line number Diff line change
Expand Up @@ -508,7 +508,7 @@ static void refill_work(struct work_struct *work)
/* In theory, this can happen: if we don't get any buffers in
* we will *never* try to fill again. */
if (still_empty)
schedule_delayed_work(&vi->refill, HZ/2);
queue_delayed_work(system_nrt_wq, &vi->refill, HZ/2);
}

static int virtnet_poll(struct napi_struct *napi, int budget)
Expand All @@ -527,7 +527,7 @@ static int virtnet_poll(struct napi_struct *napi, int budget)

if (vi->num < vi->max / 2) {
if (!try_fill_recv(vi, GFP_ATOMIC))
schedule_delayed_work(&vi->refill, 0);
queue_delayed_work(system_nrt_wq, &vi->refill, 0);
}

/* Out of packets? */
Expand Down Expand Up @@ -729,7 +729,7 @@ static int virtnet_open(struct net_device *dev)

/* Make sure we have some buffers: if oom use wq. */
if (!try_fill_recv(vi, GFP_KERNEL))
schedule_delayed_work(&vi->refill, 0);
queue_delayed_work(system_nrt_wq, &vi->refill, 0);

virtnet_napi_enable(vi);
return 0;
Expand Down

0 comments on commit f1776da

Please sign in to comment.