Skip to content

Commit

Permalink
init/Kconfig: add clarification for out-of-tree modules
Browse files Browse the repository at this point in the history
It doesn't trim just symbols that are totally unused in-tree - it trims
the symbols unused by any in-tree modules actually built.  If you've
done a 'make localmodconfig' and only build a hundred or so modules,
it's pretty likely that your out-of-tree module will come up lacking
something...

Hopefully this will save the next guy from a Homer Simpson "D'oh!"
moment.

Link: http://lkml.kernel.org/r/10177.1469787292@turing-police.cc.vt.edu
Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>
Cc: Michal Marek <mmarek@suse.cz>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Valdis Kletnieks authored and Linus Torvalds committed Aug 2, 2016
1 parent 27eb662 commit f1cb637
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion init/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -2080,7 +2080,7 @@ config TRIM_UNUSED_KSYMS
(especially when using LTO) for optimizing the code and reducing
binary size. This might have some security advantages as well.

If unsure say N.
If unsure, or if you need to build out-of-tree modules, say N.

endif # MODULES

Expand Down

0 comments on commit f1cb637

Please sign in to comment.