Skip to content

Commit

Permalink
drm/i915/perf: remove redundant variable 'taken'
Browse files Browse the repository at this point in the history
The assignment to variable taken is redundant and so it can be
removed as well as the variable too.

Cleans up clang-scan build warnings:
warning: Although the value stored to 'taken' is used in the enclosing
expression, the value is never actually read from 'taken'
[deadcode.DeadStores]

Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221007195345.2749911-1-colin.i.king@gmail.com
  • Loading branch information
Colin Ian King authored and Tvrtko Ursulin committed Oct 10, 2022
1 parent 178ce94 commit f1d8e2b
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions drivers/gpu/drm/i915/i915_perf.c
Original file line number Diff line number Diff line change
Expand Up @@ -656,7 +656,6 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,
size_t start_offset = *offset;
unsigned long flags;
u32 head, tail;
u32 taken;
int ret = 0;

if (drm_WARN_ON(&uncore->i915->drm, !stream->enabled))
Expand Down Expand Up @@ -692,7 +691,7 @@ static int gen8_append_oa_reports(struct i915_perf_stream *stream,


for (/* none */;
(taken = OA_TAKEN(tail, head));
OA_TAKEN(tail, head);
head = (head + report_size) & mask) {
u8 *report = oa_buf_base + head;
u32 *report32 = (void *)report;
Expand Down Expand Up @@ -950,7 +949,6 @@ static int gen7_append_oa_reports(struct i915_perf_stream *stream,
size_t start_offset = *offset;
unsigned long flags;
u32 head, tail;
u32 taken;
int ret = 0;

if (drm_WARN_ON(&uncore->i915->drm, !stream->enabled))
Expand Down Expand Up @@ -984,7 +982,7 @@ static int gen7_append_oa_reports(struct i915_perf_stream *stream,


for (/* none */;
(taken = OA_TAKEN(tail, head));
OA_TAKEN(tail, head);
head = (head + report_size) & mask) {
u8 *report = oa_buf_base + head;
u32 *report32 = (void *)report;
Expand Down

0 comments on commit f1d8e2b

Please sign in to comment.